为什么当我执行复制和交换惯用语时没有调用我的复制构造函数?

why isn't my copy constructor called when I do a copy and swap idiom?

提问人:Tousif 提问时间:9/17/2018 最后编辑:GeezerTousif 更新时间:9/19/2018 访问量:126

问:

在下面的代码中,当使用赋值运算符时,为什么没有调用复制构造函数,或者为什么没有与之对应的打印?

#include <iostream>
#include <cstring>

using std::cout;
using std::endl;

class Person {
private:
    char* name;
    int age;
public:
    Person() {
        name = nullptr;
        age = 10;
    }
    Person(const char* p_name, int p_age) {
        name = new char[strlen(p_name) + 1];
        strcpy(name, p_name);
        age = p_age;
    }

    Person(Person const& p) {
        cout << "Person copy constructor with " << p.name << endl;
        name = new char[strlen(p.name) + 1];
        strcpy(name, p.name);
        age = p.age;
    }

    /*self assignment
    The first is the self-assignment test. This check serves two purposes: it's an easy way to prevent us from running needless code on self-assignment,
    and it protects us from subtle bugs (such as deleting the array only to try and copy it). 
    But in all other cases it merely serves to slow the program down, and act as noise in the code; self-assignment rarely occurs, so most of the time 
    this check is a waste. It would be better if the operator could work properly without it.*/
    /*
    Person& operator=(Person const& p) {
        cout << "Person copy assignment with " << p.name << endl;
        if(this != &p){
            delete[] name;
            name = nullptr;
            name = new char[strlen(p.name) + 1];
            strcpy(name, p.name);
            age = p.age;
        }
        return *this;
    }
    */

    /*exception safety
    If in the previous approach the memory allocation fails and throws an exception then the data in name is gone*/
    /*
    Person& operator=(Person const& p) {
        cout << "Person copy assignment with " << p.name << endl;
        char* temp_name = new char[strlen(p.name) + 1];
        strcpy(temp_name, p.name);
        delete[] name;
        name = temp_name;
        age = p.age;
        return *this;
    }
    */

    //copy and swap idiom
    /*
    . Not only that, but this choice is critical in C++11, which is discussed later.
    (On a general note, a remarkably useful guideline is as follows: if you're going to make a copy of something in a function,
    let the compiler do it in the parameter list.‡)
    */
    Person& operator=(Person p) {
        cout << "Person copy assignment with " << p.name << endl;
        swap(*this, p);
        return *this;
    }

    /*
    A swap function is a non-throwing function that swaps two objects of a class, member for member. We might be tempted to 
    use std::swap instead of providing our own, but this would be impossible; std::swap uses the copy-constructor and 
    copy-assignment operator within its implementation, and we'd ultimately be trying to define the assignment operator in terms of itself!
    */
    friend void swap(Person &a, Person &b) {
        using std::swap;
        swap(a.name, b.name);
        swap(a.age, b.age);
    }

    Person(Person&& other) {
        swap(*this, other);
    }

    ~Person() {
        if(name)
            cout << "Person destructor called for " << name << endl;
        delete[] name;
    }
};

int main() {
    Person p("Ryan", 28);
    Person a(p);
    a = p;
    cout << "Hello World" << endl;

    return 0;
}

上述代码的输出为:

Person copy constructor with Ryan
Person copy constructor with Ryan
Person copy assignment with Ryan
Person destructor called for Ryan
Hello World
Person destructor called for Ryan
Person destructor called for Ryan
C++ 构造函数 赋值运算符 复制和交换

评论

3赞 StoryTeller - Unslander Monica 9/17/2018
你说没有印刷是什么意思?第二行就是这样。你期待另一个在哪里?
0赞 Geezer 9/17/2018
为什么关闭?根据输出,复制构造函数被调用得很好:)
0赞 john 9/17/2018
我猜 OP 希望复制构造函数消息出现在复制分配消息之后。
1赞 darune 9/17/2018
这不是重复的,至少是提到的那个。复制构造函数不会被省略(如预期的那样)。事实上,Copy 构造函数是在赋值之前调用的 - 与打印行相符。(至 OP:尝试在行前插入打印件a = p;)
2赞 Fureeish 9/17/2018
@SkepticalEmpiricist你现在有机会完成你的答案:)

答:

4赞 Geezer 9/17/2018 #1

为什么没有调用复制构造函数/没有与之对应的打印。

实际上,它被称作很好。您可以在自己的输出中看到:

Person copy constructor with Ryan
Person copy constructor with Ryan <--- This is it : )
Person copy assignment with Ryan

请看这里是呼叫站点:

a = p;

这是您的赋值运算符:

Person& operator=(Person p) {
    cout << "Person copy assignment with " << p.name << endl;
    swap(*this, p);
    return *this;
}

所以这里为谁调用了复制构造函数?什么时候?在输入代码正文之前,会针对此参数调用它(使用来自调用站点的 RHS 作为其参数)。因此,在输出中,您会看到它是紧挨着这一行的行:p=operator=

Person copy assignment with Ryan